Fix state hash size check in fast implementation #118
+7
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fast implementation calculates the state hash from the state witness in the StateWitness.StateHash function.
However, this function implements a length check that is insufficient. The expected length is known to be
362
but the implementation checks that the length is greater than32 + 32 + 8 + 8 + 1 = 81
. We should check the state witness length is equal to the expected length.