-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sep): Stage 1.4 upgrade #390
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing the cannon dispute game to new kona one:
Matches version()(string) = "1.3.1"
Mismatch absolutePrestate()(bytes32)
Was: 0x03925193e3e89f87835bbdf3a813f60b2aa818a36bbe71cd5d8fd7e79f5e8afe
Now: 0x03c870fe570f921d72bcdb89b051c4b4ff3d0799e9629603b0e6065d796ddab7
Matches maxGameDepth()(uint256) = 73
Matches splitDepth()(uint256) = 30
Matches maxClockDuration()(uint256) = 302400 [3.024e5]
Mismatch gameType()(uint32)
Was: 0
Now: 3
Matches l2ChainId()(uint256) = 11155420 [1.115e7]
Matches clockExtension()(uint64) = 10800 [1.08e4]
Matches anchorStateRegistry()(address) = 0x218CD9489199F321E1177b56385d333c5B598629
Comparing WETH
Mismatch version()(string)
Was: "1.2.0-beta.3"
Now: "1.1.0"
Matches delay()(uint256) = 604800 [6.048e5]
Matches config()(address) = 0xC2Be75506d5724086DEB7245bd260Cc9753911Be
Comparing vm
Mismatch version()(string)
Was: "1.2.1"
Now: "1.2.0"
So we've wound up incorrectly upgrading DelayedWETH implementation.
The other changes match what I'd expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DelayedWETH version problem is actually the other way around. It was deployed wrong with Holocene for the cannon game type and the new kona game type has it right. So LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SAFE_NONCE
is not present in the .env
for now. I am not sure what nonce will be used probably the same as:
SAFE_NONCE=""
And will take the last nonce but maybe for precedent would be nice to keep it?
|
||
## Pre-deployments | ||
|
||
- `RISCV` - `0x7f9a34da8d240bbe039e9f7b497c9bc500f6acf5` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I found these addresses predeployed?
For Mainnet, this one would be inside the gov proposal, right?
## Pre-deployments | ||
|
||
- `RISCV` - `0x7f9a34da8d240bbe039e9f7b497c9bc500f6acf5` | ||
- `DelayedWETHProxy` - `0x3c024f698c27a914350531bc48033e62d42703e0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version here doesn't seems to be the v.1.9.0-rc.3
As the version is different here
string public constant version = "1.1.0";
instead of v.1.9.0-rc.3
string public constant version = "1.2.0-beta.4";
Could we make sure we are deploying the exact same version for clarity? or instead adding the version used for this contract?
## Simulation | ||
|
||
Please see the "Simulating and Verifying the Transaction" instructions in [NESTED.md](../../../NESTED.md). | ||
When simulating, ensure the logs say `Using script /your/path/to/superchain-ops/tasks/sep/021-stage-1-4/NestedSignFromJson.s.sol`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using script /your/path/to/superchain-ops/tasks/sep/021-stage-1-4/NestedSignFromJson.s.sol
.
We already have open PRs with the id=21
.
it would be nice to rename the task with id=22
and also the folder of the task if possible.
For posterity, this task has been already executed in this tx |
Overview
Contains the Stage 1.4 upgrade for
sep
.