sep/027: upgrade and re-initialize `SystemConfig` across sepolia superchain #418

geoknee · 2024-12-17T14:36:47Z

Closes #394

See also #454

TODO

upgrade to a multi chain task when things are working for OP Sepolia
add some breadcrumbs to the previous task 020 to signify that it was incorrect and that this task supercedes it
Build on top of @sebastianst 's new validation framework 3591eec

tasks/sep/026-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/NestedSignFromJson.s.sol

script/verification/Verification.s.sol

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/OVERVIEW.md

existing task in flight for 025

Closes #423

…ave them, e.g. metal)

…kip only if not found in the TOML file

…s into child contract

…d rename to HoloceneSystemConfigUpgrade

script/verification/HoloceneSystemConfigUpgrade.s.sol

geoknee · 2025-01-09T17:43:50Z

script/verification/HoloceneSystemConfigUpgrade.s.sol

+            require(previousScalar >> 248 == 0, "scalar-101 previous scalar version != 0 or 1");
+            require(reencodedScalar >> 248 == 1, "scalar-102 reenconded scalar version != 1");
+            require(sysCfg.blobbasefeeScalar() == uint32(0), "scalar-103 blobbasefeeScalar !=0");
+            require(reencodedScalar << 8 == previousScalar << 8, "scalar-104 scalar mismatch");


Two comments on this:

It's not very clear, if we define a variable or at least put in the revert reason "baseFeeScalar" that would help a lot

The bit shift looks wrong, we probably want << 32 instead of << 8

Looks like this is not working indeed, i tried with the mask 0xfffff and this seems to have a more reasonable value @geoknee:

Fixed this here. In fact what I was trying to do was compare the scalars without the scalar version (first byte). 556d1d5

Hmm,
Just to make sure, you want to compare the if the first byte (0x0) are correctly incremented to (0x1) when the value scalarVersion is 0 right (if yes for me it works as expected).

Ethnical · 2025-01-09T18:54:25Z

lib/forge-std

Make sure this is not causing issue during simulation + broadcast (cf: This issue we had on the previous upgrades: feat(forge script): script broadcast dry runs should log transaction info to the terminal foundry-rs/foundry#9648)

Ethnical · 2025-01-09T20:45:58Z

script/verification/IResourceMetering.sol

+
+    function params() external view returns (uint128 prevBaseFee, uint64 prevBoughtGas, uint64 prevBlockNum); // nosemgrep
+
+    function __constructor__() external;


function __constructor__() external;

NIT: curious to know if this is required?

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md

Ethnical · 2025-01-09T21:04:56Z

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md

+- **Key**: `0x0000000000000000000000000000000000000000000000000000000000000068`
+  **Before**: `0x0000000000000000000000000000000000000000000000000000000003938700`
+  **After**: `0xx00000000000000000000000000000000000d273000001db00000000003938700`
+  **Meaning**: Updates the `basefeeScalar` and `blobbasefeeScalar` storage variables to `7600` and `86200` respectively. These share a slot with the `gasLimit` which remans at `60000000`


@geoknee there is an error here the state is updating with 862000.
We should make sure this is desired and this is a simple typo here:

`86200` respectively.

Yes you are right this is a typo. I decoded it again by hand and have corrected the doc.

Ethnical · 2025-01-09T21:07:09Z

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md

+- **Key**: `0x0000000000000000000000000000000000000000000000000000000000000068`
+  **Before**: `0x0000000000000000000000000000000000000000000000000000000001c9c380`
+  **After**: `0x0000000000000000000000000000000000000000000a6fe00000000001c9c380`
+  **Meaning**: Updates the `basefeeScalar` and `blobbasefeeScalar` storage variables to `68400` and `0` respectively. These share a slot with the `gasLimit` which remans at `30000000`


@geoknee there is an error here the state is updating with 684000.
We should make sure this is desired and this is a simple typo here:

to `68400`

Yes you are right this is a typo. I decoded it again by hand and have corrected the doc.

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md

Ethnical

Super work with the framework for the SuperConfig upgrade! 🔥

The validation "storage" matched the simulation. But some value into the validation file need to be revisited.
There is few things to complete before merge but would be fast!

do not use << 8 to trim encoding version

…ain/VALIDATION.md Co-authored-by: Ethnical <[email protected]>

Ethnical

LGTM! rechecked the tasks validation + simulation make sense to me!

geoknee changed the title ~~first pass at task sep 025~~ Sep 026: upgrade and re-initialize SystemConfig Dec 17, 2024

geoknee mentioned this pull request Dec 17, 2024

Fix Holocene SystemConfig upgrade scripts ethereum-optimism/optimism#13412

Merged

3 tasks

geoknee commented Dec 17, 2024

View reviewed changes

tasks/sep/026-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md Outdated Show resolved Hide resolved

geoknee changed the title ~~Sep 026: upgrade and re-initialize SystemConfig~~ Sep 027: upgrade and re-initialize SystemConfig Dec 18, 2024

geoknee force-pushed the gk/025-holocene-sys-cfg branch 2 times, most recently from 50aeb48 to 2e881b4 Compare December 19, 2024 14:58

sebastianst reviewed Dec 19, 2024

View reviewed changes

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/NestedSignFromJson.s.sol Outdated Show resolved Hide resolved

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/NestedSignFromJson.s.sol Outdated Show resolved Hide resolved

geoknee commented Jan 3, 2025

View reviewed changes

script/verification/Verification.s.sol Outdated Show resolved Hide resolved

geoknee commented Jan 3, 2025

View reviewed changes

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/OVERVIEW.md Outdated Show resolved Hide resolved

geoknee added 21 commits January 4, 2025 00:07

first pass at task sep 025

e5623ea

bump task index

14500b8

existing task in flight for 025

undo change to submodule

9c83d58

add exceptions for EOAs in SystemConfig storage

cc782b3

bump task sequence number

dcd607c

change validation script to use Seb's new framework

c04293c

addAllowedStorageAccess for each system config

eb21f18

SystemConfigUpgrade exposes code exceptions thru getter

4014438

introduce SystemConfigUpgradeEcotoneScalars

fcda94c

add deprecation notice to task 020

d130513

remove unecessary forge build commands

ef18399

Closes #423

add some logging

35b4718

reactivate all chains

1355535

update to superbundle

bb163d9

TEMP: do not try to load all contract addresses (some chains do not h…

0b39283

…ave them, e.g. metal)

improve err msg

85aac3a

fix superbundle

ca3699e

use dynamic storage array

7b7f0d1

validate in a smarter way for chains migrating from pre ecotone scalars

80aa1cc

SuperchainRegistry: instead of skipping missing addresses globally, s…

7e0c7fe

…kip only if not found in the TOML file

update overview and readme

127d370

geoknee added 5 commits January 9, 2025 11:23

SystemConfigUpgrade: pull gasPayingToken and disputeGameFactory check…

d2162ee

…s into child contract

combine SystemConfigUpgrade with SystemConfigUpgradeEcotoneScalars an…

4892a5c

…d rename to HoloceneSystemConfigUpgrade

tidy

06f91d1

some more improvements

566477e

more code comments

497007f

geoknee changed the title ~~sep/027: upgrade and re-initialize SystemConfig~~ sep/027: upgrade and re-initialize SystemConfig across sepolia superchain Jan 9, 2025

geoknee commented Jan 9, 2025

View reviewed changes

script/verification/HoloceneSystemConfigUpgrade.s.sol Outdated Show resolved Hide resolved

geoknee commented Jan 9, 2025

View reviewed changes

script/verification/HoloceneSystemConfigUpgrade.s.sol Outdated Show resolved Hide resolved

geoknee commented Jan 9, 2025

View reviewed changes

script/verification/HoloceneSystemConfigUpgrade.s.sol Outdated Show resolved Hide resolved

geoknee commented Jan 9, 2025

View reviewed changes

Ethnical reviewed Jan 9, 2025

View reviewed changes

Ethnical self-assigned this Jan 9, 2025

Ethnical reviewed Jan 9, 2025

View reviewed changes

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md Outdated Show resolved Hide resolved

Ethnical reviewed Jan 9, 2025

View reviewed changes

tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md Outdated Show resolved Hide resolved

Ethnical reviewed Jan 9, 2025

View reviewed changes

geoknee and others added 11 commits January 10, 2025 09:47

Update script/verification/HoloceneSystemConfigUpgrade.s.sol

e843ff4

Update script/verification/HoloceneSystemConfigUpgrade.s.sol

7c2a9c8

typos

a44a491

refactor for readability

556d1d5

do not use << 8 to trim encoding version

consolidate interfaces into one file

cd7ec86

Update tasks/sep/027-holocene-system-config-upgrade-and-init-multi-ch…

a14b6a3

…ain/VALIDATION.md Co-authored-by: Ethnical <[email protected]>

typos

1389e43

Update tasks/sep/027-holocene-system-config-upgrade-and-init-multi-ch…

1a12121

…ain/VALIDATION.md Co-authored-by: Ethnical <[email protected]>

improve formatting and links

ce9614d

Merge remote-tracking branch 'origin/main' into gk/025-holocene-sys-cfg

89e4726

tidy

ef7ccef

Ethnical approved these changes Jan 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sep/027: upgrade and re-initialize `SystemConfig` across sepolia superchain #418

sep/027: upgrade and re-initialize `SystemConfig` across sepolia superchain #418

geoknee commented Dec 17, 2024 •

edited

Loading

geoknee Jan 9, 2025

Ethnical Jan 9, 2025

geoknee Jan 10, 2025

Ethnical Jan 10, 2025

Ethnical Jan 9, 2025

Ethnical Jan 9, 2025 •

edited

Loading

geoknee Jan 10, 2025

Ethnical Jan 9, 2025

geoknee Jan 10, 2025

Ethnical Jan 9, 2025

geoknee Jan 10, 2025

Ethnical left a comment •

edited

Loading

Ethnical left a comment


		function params() external view returns (uint128 prevBaseFee, uint64 prevBoughtGas, uint64 prevBlockNum); // nosemgrep

		function __constructor__() external;

sep/027: upgrade and re-initialize SystemConfig across sepolia superchain #418

Are you sure you want to change the base?

sep/027: upgrade and re-initialize SystemConfig across sepolia superchain #418

Conversation

geoknee commented Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ethnical Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ethnical left a comment • edited Loading

Choose a reason for hiding this comment

Ethnical left a comment

Choose a reason for hiding this comment

sep/027: upgrade and re-initialize `SystemConfig` across sepolia superchain #418

sep/027: upgrade and re-initialize `SystemConfig` across sepolia superchain #418

geoknee commented Dec 17, 2024 •

edited

Loading

Ethnical Jan 9, 2025 •

edited

Loading

Ethnical left a comment •

edited

Loading