-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utp packet heap #702
Merged
Merged
Utp packet heap #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
reviewed
Jan 10, 2025
acolytec3
requested changes
Jan 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, with one change for clarity needed I think. Otherwise, go ahead and merge and don't wait for an approval from me
packages/portalnetwork/src/wire/utp/PortalNetworkUtp/requestManager.ts
Outdated
Show resolved
Hide resolved
acolytec3
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces uTP Packet Queue array with
Heap
fromheap-js
.Heap will sort packets waiting in queue so that out-of-order packets are reordered. This will cut back on unnecessary
Selective Ack
responses.When receiving streams, especially from
Trin
nodes, we often receive pairs of packets with identical timestamps, and regularly end up processing them in the wrong order.Selective Ack
function. We report every other packet at missing, even though it isn't. So We get multiples of every other packet and send extraACK
packets.The
processCurrentPacket
method was updated to skip repeat packets, and to requeue packets that arrive ahead of the current reader position. This update allows the packet-pair phenomenon to self correct.Also updated and improved some logs, and added a method to report the total number of open uTP streams.