Skip to content

feat: fold EIP-8198 slot duration into Heze - #896

Merged
barnabasbusa merged 10 commits into
masterfrom
bbusa/heze-eip8198
Oct 19, 2026
Merged

barnabasbusa merged 10 commits into
masterfrom
bbusa/heze-eip8198

Conversation

@barnabasbusa

Copy link
Copy Markdown
Collaborator

Follows ethereum/consensus-specs#5718 (still open), which adds EIP-8198 (Quick Slots) to Heze now that it has been CFI'd: the separate EIP8198_FORK_* fork is dropped and SLOT_DURATION_MS_HEZE applies from HEZE_FORK_EPOCH. Dora removes the standalone EIP-8198 fork from the fork lists and fork version lookup, derives the wallclock schedule from SLOT_DURATION_MS_HEZE, computes inclusion list due times from the slot's actual duration, and scales the Heze activation, exit and consolidation churn limits by the slot duration ratio as the spec does. Stacked on #895; hold until #5718 is merged.

🤖 Generated with Claude Code

@redpandabot redpandabot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folds the standalone EIP-8198 fork into Heze: removes the EIP8198_FORK_* config/lookup and data-version alias, derives the slot-duration schedule from SLOT_DURATION_MS_HEZE, computes inclusion-list due times from the slot's actual duration, and scales the Heze activation/exit/consolidation churn limits by the slot-duration ratio. I checked the churn scaling, schedule mapping, inclusion-list changes and fork-list/version removal against consensus-specs#5718 and the final source; the implementation matches the spec and I found no defects in the change.


Reviewed 8 changed file(s) @ 8599d69e — no blocking issues found.
"First we travel, then we tell the wife."

@barnabasbusa
barnabasbusa force-pushed the bbusa/heze-eip8198 branch 3 times, most recently from 3642b0e to 998d0fb Compare October 9, 2026 11:33
barnabasbusa and others added 2 commits October 9, 2026 13:35
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@redpandabot

This comment has been minimized.

@redpandabot redpandabot Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Folds the EIP-8198 fork into Heze: removes the standalone fork from specs/fork lists, derives wallclock segments from SLOT_DURATION_MS_HEZE, uses the slot's actual duration for inclusion-list due times, and scales Heze churn limits by the duration ratio. Verified the cap-before-scale, round-after-scaling order and the test values against consensus-specs PR #5718 — they match; the clientlogic finality-seeding fix is safe. One edge-case finding from the previous review remains open.

Issues

  • 🟡 clients/consensus/chainstate.go:682 — churn ratio divides by raw SLOT_DURATION_MS instead of the genesis-epoch duration — see the thread on that line

Reviewed @ eb6178e8
"First we travel, then we tell the wife."

Comment thread clients/consensus/chainstate.go
@barnabasbusa
barnabasbusa force-pushed the bbusa/eip8198-slot-duration-beta4 branch from c83e4e8 to b896613 Compare October 9, 2026 13:01
Base automatically changed from bbusa/eip8198-slot-duration-beta4 to master October 12, 2026 13:02
@barnabasbusa barnabasbusa added the build-docker-image Automatically build docker image for PR branch label Oct 15, 2026

@redpandabot redpandabot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of head 0e86843760d035b6d32d373035568660d65801a1. Review scope is incomplete; these findings do not constitute a clean verdict.

Evidence basis: source inspection at pinned revisions.

Comment thread clients/consensus/chainstate.go
@barnabasbusa
barnabasbusa disabled auto-merge October 19, 2026 11:37
@barnabasbusa
barnabasbusa merged commit 7eb22e6 into master Oct 19, 2026
16 checks passed
@barnabasbusa
barnabasbusa deleted the bbusa/heze-eip8198 branch October 19, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-docker-image Automatically build docker image for PR branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants