Repository navigation
feat: fold EIP-8198 slot duration into Heze - #896
Conversation
There was a problem hiding this comment.
Folds the standalone EIP-8198 fork into Heze: removes the EIP8198_FORK_* config/lookup and data-version alias, derives the slot-duration schedule from SLOT_DURATION_MS_HEZE, computes inclusion-list due times from the slot's actual duration, and scales the Heze activation/exit/consolidation churn limits by the slot-duration ratio. I checked the churn scaling, schedule mapping, inclusion-list changes and fork-list/version removal against consensus-specs#5718 and the final source; the implementation matches the spec and I found no defects in the change.
Reviewed 8 changed file(s) @ 8599d69e — no blocking issues found.
"First we travel, then we tell the wife."
3642b0e to
998d0fb
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
998d0fb to
44228f3
Compare
This comment has been minimized.
This comment has been minimized.
44228f3 to
d5193c2
Compare
There was a problem hiding this comment.
Summary
Folds the EIP-8198 fork into Heze: removes the standalone fork from specs/fork lists, derives wallclock segments from SLOT_DURATION_MS_HEZE, uses the slot's actual duration for inclusion-list due times, and scales Heze churn limits by the duration ratio. Verified the cap-before-scale, round-after-scaling order and the test values against consensus-specs PR #5718 — they match; the clientlogic finality-seeding fix is safe. One edge-case finding from the previous review remains open.
Issues
- 🟡
clients/consensus/chainstate.go:682— churn ratio divides by raw SLOT_DURATION_MS instead of the genesis-epoch duration — see the thread on that line
Reviewed @ eb6178e8
"First we travel, then we tell the wife."
c83e4e8 to
b896613
Compare
d5193c2 to
44228f3
Compare
Follows ethereum/consensus-specs#5718 (still open), which adds EIP-8198 (Quick Slots) to Heze now that it has been CFI'd: the separate
EIP8198_FORK_*fork is dropped andSLOT_DURATION_MS_HEZEapplies fromHEZE_FORK_EPOCH. Dora removes the standalone EIP-8198 fork from the fork lists and fork version lookup, derives the wallclock schedule fromSLOT_DURATION_MS_HEZE, computes inclusion list due times from the slot's actual duration, and scales the Heze activation, exit and consolidation churn limits by the slot duration ratio as the spec does. Stacked on #895; hold until #5718 is merged.🤖 Generated with Claude Code