Code

Add check favorite session feature#4

Code

Open

ewa1989 wants to merge 25 commits intomainewa1989/trySwiftTokyoApp:mainfrom add-check-favorite-session-featureewa1989/trySwiftTokyoApp:add-check-favorite-session-featureCopy head branch name to clipboard

+231-13

Commits

Commits on Mar 17, 2024

• add star icon in the right of session row

  ewa1989

  committed
  875b195

  Copy full SHA for 875b195

• change icon according to the session is favorited

  ewa1989

  committed
  33888d9

  Copy full SHA for 33888d9

• create new action, view favoriteIconTapped

  ewa1989

  committed
  08a2b0d

  Copy full SHA for 08a2b0d

• change to toggle favorite condition of tapped session

  ewa1989

  committed
  c32c5bf

  Copy full SHA for c32c5bf

• change to save and load conferences in UserDefaullts

  ewa1989

  committed
  cf49338

  Copy full SHA for cf49338

Commits on Mar 18, 2024

• Merge commit '1b5005da964abcaf5a5865b68347ab32d6e72aa2' into add-check-favorite-session-feature

  Show description for 5a32df4
  ewa1989

  committed
  5a32df4

  Copy full SHA for 5a32df4

Commits on Mar 20, 2024

• change save data type as [String: [Session]] for performance

  ewa1989

  committed
  846098f

  Copy full SHA for 846098f

• extract favorites load/save methods to FileClient, separating with fetching methods which might change API Client in future

  ewa1989

  committed
  23983b5

  Copy full SHA for 23983b5

• Merge branch 'main' into add-check-favorite-session-feature

  Show description for a7a611b
  ewa1989

  committed
  a7a611b

  Copy full SHA for a7a611b

• change file save/load area to Document that is more appropriate because favorite data aren't customizing app's behavior

  ewa1989

  committed
  0e8b403

  Copy full SHA for 0e8b403

• fix failed test due to adding load Favorites when onAppear

  ewa1989

  committed
  daa7fa7

  Copy full SHA for daa7fa7

• separate saving favorites and updating state for testability

  ewa1989

  committed
  1a5419a

  Copy full SHA for 1a5419a

• add tests for adding/removing favorites

  ewa1989

  committed
  35b4d14

  Copy full SHA for 35b4d14

• extract json encoder and decorder as JSONHandler

  ewa1989

  committed
  f2622b8

  Copy full SHA for f2622b8

Commits on Mar 21, 2024

• Revert "extract json encoder and decorder as JSONHandler"

  Show description for b648df2
  ewa1989

  committed
  b648df2

  Copy full SHA for b648df2

• separate FileClient

  ewa1989

  committed
  a929586

  Copy full SHA for a929586

• move mocks that are intended for specific behavior near related tests

  ewa1989

  committed
  4e279e4

  Copy full SHA for 4e279e4

• Merge branch 'main' into add-check-favorite-session-feature

  Show description for 1db51b5
  ewa1989

  committed
  1db51b5

  Copy full SHA for 1db51b5

Commits on Mar 31, 2024

• remove unused mock

  ewa1989

  committed
  d3a49ab

  Copy full SHA for d3a49ab

• fix to separate load favorites from fetch data, and to assert separately in tests.

  ewa1989

  committed
  04cefc0

  Copy full SHA for 04cefc0

• to keep models having no logics, move logics in Favorites to Reducer and View, and remove Favorites and use typealias instead because Favorites has one property only.

  ewa1989

  committed
  d3b9901

  Copy full SHA for d3b9901

• rename saveDataToFile and loadDataFromFile to explain exactly how they do.

  ewa1989

  committed
  cfb2fa3

  Copy full SHA for cfb2fa3

Commits on Apr 1, 2024

• change variable name of Conference, day to conference, as other place does

  ewa1989

  committed
  77b7a09

  Copy full SHA for 77b7a09

Commits on Apr 11, 2024

• fix to combine load response into fetch response for simplicity.

  ewa1989

  committed
  0e3b9f8

  Copy full SHA for 0e3b9f8

• move a part of logic to Reducer for collecting logics relative with state

  ewa1989

  committed
  6cca9bd

  Copy full SHA for 6cca9bd