Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triangle: return int, fixes #164 #202

Merged
merged 3 commits into from
Feb 16, 2024
Merged

triangle: return int, fixes #164 #202

merged 3 commits into from
Feb 16, 2024

Conversation

sudhackar
Copy link
Contributor

As discussed in #164 - this should enforce returning 1/0 instead of true/false.

Copy link

github-actions bot commented Feb 5, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 5, 2024
@ErikSchierboom
Copy link
Member

CI is failing

@sudhackar
Copy link
Contributor Author

will fix

@sudhackar
Copy link
Contributor Author

CI passed. ready to merge

@ErikSchierboom ErikSchierboom merged commit eadbe59 into exercism:main Feb 16, 2024
4 checks passed
@ErikSchierboom
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants