Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sks acc tests: remove an unnecessary check #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sauterp
Copy link
Member

@sauterp sauterp commented Sep 5, 2023

Description

We remove a check that waits for an update to an SKS cluster to happen. It's not necessary (anymore) as the provider does a similar check before.

Checklist

  • Changelog updated (under Unreleased block)
  • Acceptance tests OK
  • For a new resource, datasource or new attributes: acceptance test added/updated

Testing

Ran the test locally and it failed due to a known issue not related to this change:

=== RUN   TestAccResourceSKSCluster
    resource_exoscale_sks_cluster_test.go:181: Step 2/3 error: Error running apply: exit status 1

        Error: context deadline exceeded

          with exoscale_sks_cluster.test,
          on terraform_plugin_test.tf line 6, in resource "exoscale_sks_cluster" "test":
           6: resource "exoscale_sks_cluster" "test" {

--- FAIL: TestAccResourceSKSCluster (401.42s)
FAIL
exit status 1
FAIL	github.com/exoscale/terraform-provider-exoscale/exoscale	401.427s

@sauterp sauterp added the HOLD ✋ Hold, don't merge (no review queue) label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HOLD ✋ Hold, don't merge (no review queue)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant