Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sos: introduce bucket policy resource #391

Merged
merged 22 commits into from
Nov 20, 2024

Conversation

sauterp
Copy link
Member

@sauterp sauterp commented Oct 30, 2024

Description

Since the AWS provider isn't compatible anymore with our bucket policy format we introduce our own resource for this purpose.

It was necessary to update github.com/hashicorp/terraform-plugin-testing because it required each resource to have an "id" attribute, which is not actually required by terraform itself, only by this testing library. Thus this requirement was removed in v1.5.0.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Acceptance tests OK
  • For a new resource, datasource or new attributes: acceptance test added/updated

Testing

=== RUN   TestSOSBucketPolicy
--- PASS: TestSOSBucketPolicy (129.50s)
PASS
ok  	github.com/exoscale/terraform-provider-exoscale/pkg/resources/sos_bucket_policy	129.513s

@sauterp sauterp force-pushed the philippsauter/sc-107256/sos-bucket-policy branch from 8a81ac9 to 649c62b Compare October 31, 2024 18:50
@sauterp sauterp marked this pull request as ready for review November 8, 2024 16:45
@sauterp
Copy link
Member Author

sauterp commented Nov 12, 2024

I'd like to update the govulncheck dependencies in a separate PR. This one already updates some necessary ones and is a quarter of a million lines of code :/

@sauterp sauterp force-pushed the philippsauter/sc-107256/sos-bucket-policy branch from 6c3aa25 to 1e090cc Compare November 13, 2024 14:43
pkg/sos/sos.go Outdated Show resolved Hide resolved
@sauterp sauterp requested a review from kobajagi November 18, 2024 17:32
@sauterp sauterp force-pushed the philippsauter/sc-107256/sos-bucket-policy branch from a361bc4 to 2a5ea67 Compare November 20, 2024 17:35
@sauterp sauterp merged commit 1cdf32c into master Nov 20, 2024
1 of 3 checks passed
@sauterp sauterp deleted the philippsauter/sc-107256/sos-bucket-policy branch November 20, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants