dbaas: support for users #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrondier
force-pushed
the
tgrondier/sc-104245/tf-provider-dbaas-users
branch
from
ec9e8ea to
907c87b
Compare
|
Also fixes #326 |
tgrondier
force-pushed
the
tgrondier/sc-104245/tf-provider-dbaas-users
branch
from
907c87b to
61fd030
Compare
|
One test seems to be failing. Probably unrelated to this PR but it's DBaaS related. Just to be sure. |
sauterp
approved these changes
Dec 20, 2024
pierre-emmanuelJ
approved these changes
Dec 20, 2024
Yes I can't reproduce the issue, seems to have been transient. |
I tested it a bit more on my side: it seems when a mysql dbaas goes from Unsure how to handle that edge case in the tests EDIT: Updated to wait for MySQL DBAAS to be running before allowing user updates |
tgrondier
force-pushed
the
tgrondier/sc-104245/tf-provider-dbaas-users
branch
2 times, most recently
from
13ef3a1 to
54cf5b0
Compare
Co-authored-by: Philipp Sauter <[email protected]>
tgrondier
force-pushed
the
tgrondier/sc-104245/tf-provider-dbaas-users
branch
from
54cf5b0 to
9ce0c14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For services that allow user creation, we are adding new resources that correspond to a user.
Checklist
(For exoscale contributors)
Testing
Local tests + acceptance tests