Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 6.6.1 #245

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ buildscript {
truth: 'com.google.truth:truth:0.36',
robolectric: 'org.robolectric:robolectric:2.4',
compiletesting: 'com.google.testing.compile:compile-testing:0.12',
spotless: 'com.diffplug.spotless:spotless-plugin-gradle:3.6.0',
spotless: 'com.diffplug.spotless:spotless-plugin-gradle:4.5.1',
]

repositories {
Expand All @@ -48,10 +48,10 @@ subprojects {

apply plugin: "com.diffplug.gradle.spotless"

def checkSubTask = project.tasks.findByName('check')
if(checkSubTask) {
tasks['check'].dependsOn checkSubTask
}
// def checkSubTask = project.tasks.findByName('check')
// if(checkSubTask) {
// tasks['check'].dependsOn checkSubTask
// }
Comment on lines +51 to +54
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to disable this because it is circular dependencies on henson-plugin:check task (detected on latest spotless version). What does checkSubtask doing in this case ? do you have any concern if we remove this ?

def installSubTask = project.tasks.findByName('install')
if(installSubTask) {
tasks['install'].dependsOn installSubTask
Expand Down
26 changes: 26 additions & 0 deletions dart-processor-test/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
apply plugin: 'java-library'

sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8

tasks.withType(JavaCompile) {
options.annotationProcessorPath = configurations.annotationProcessor
}

dependencies {
implementation project(':dart-annotations')
implementation project(':dart-common')
implementation project(':dart')
implementation deps.javapoet
implementation deps.parceler.runtime
compileOnly deps.android.runtime
annotationProcessor project(':dart-processor')
implementation project(':dart-processor')

testImplementation files(org.gradle.internal.jvm.Jvm.current().getToolsJar())
testImplementation deps.junit
testImplementation deps.compiletesting
testImplementation deps.truth
testImplementation deps.fest
testImplementation deps.android.runtime
}
3 changes: 3 additions & 0 deletions dart-processor-test/gradle.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
POM_ARTIFACT_ID=dart-processor
POM_NAME=Dart Annotation Processor
POM_PACKAGING=jar
7 changes: 0 additions & 7 deletions dart-processor/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,4 @@ dependencies {
implementation deps.javapoet
implementation deps.parceler.runtime
compileOnly deps.android.runtime

testImplementation files(org.gradle.internal.jvm.Jvm.current().getToolsJar())
testImplementation deps.junit
testImplementation deps.compiletesting
testImplementation deps.truth
testImplementation deps.fest
testImplementation deps.android.runtime
}
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
3 changes: 1 addition & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#Wed Dec 06 17:59:39 PST 2017
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.3-all.zip
168 changes: 84 additions & 84 deletions gradlew.bat
Original file line number Diff line number Diff line change
@@ -1,84 +1,84 @@
@if "%DEBUG%" == "" @echo off
@rem ##########################################################################
@rem
@rem Gradle startup script for Windows
@rem
@rem ##########################################################################

@rem Set local scope for the variables with windows NT shell
if "%OS%"=="Windows_NT" setlocal

set DIRNAME=%~dp0
if "%DIRNAME%" == "" set DIRNAME=.
set APP_BASE_NAME=%~n0
set APP_HOME=%DIRNAME%

@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
set DEFAULT_JVM_OPTS=

@rem Find java.exe
if defined JAVA_HOME goto findJavaFromJavaHome

set JAVA_EXE=java.exe
%JAVA_EXE% -version >NUL 2>&1
if "%ERRORLEVEL%" == "0" goto init

echo.
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
echo.
echo Please set the JAVA_HOME variable in your environment to match the
echo location of your Java installation.

goto fail

:findJavaFromJavaHome
set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE=%JAVA_HOME%/bin/java.exe

if exist "%JAVA_EXE%" goto init

echo.
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
echo.
echo Please set the JAVA_HOME variable in your environment to match the
echo location of your Java installation.

goto fail

:init
@rem Get command-line arguments, handling Windows variants

if not "%OS%" == "Windows_NT" goto win9xME_args

:win9xME_args
@rem Slurp the command line arguments.
set CMD_LINE_ARGS=
set _SKIP=2

:win9xME_args_slurp
if "x%~1" == "x" goto execute

set CMD_LINE_ARGS=%*

:execute
@rem Setup the command line

set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar

@rem Execute Gradle
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%

:end
@rem End local scope for the variables with windows NT shell
if "%ERRORLEVEL%"=="0" goto mainEnd

:fail
rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
rem the _cmd.exe /c_ return code!
if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1
exit /b 1

:mainEnd
if "%OS%"=="Windows_NT" endlocal

:omega
@if "%DEBUG%" == "" @echo off
@rem ##########################################################################
@rem
@rem Gradle startup script for Windows
@rem
@rem ##########################################################################
@rem Set local scope for the variables with windows NT shell
if "%OS%"=="Windows_NT" setlocal
set DIRNAME=%~dp0
if "%DIRNAME%" == "" set DIRNAME=.
set APP_BASE_NAME=%~n0
set APP_HOME=%DIRNAME%
@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
set DEFAULT_JVM_OPTS=
@rem Find java.exe
if defined JAVA_HOME goto findJavaFromJavaHome
set JAVA_EXE=java.exe
%JAVA_EXE% -version >NUL 2>&1
if "%ERRORLEVEL%" == "0" goto init
echo.
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
echo.
echo Please set the JAVA_HOME variable in your environment to match the
echo location of your Java installation.
goto fail
:findJavaFromJavaHome
set JAVA_HOME=%JAVA_HOME:"=%
set JAVA_EXE=%JAVA_HOME%/bin/java.exe
if exist "%JAVA_EXE%" goto init
echo.
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
echo.
echo Please set the JAVA_HOME variable in your environment to match the
echo location of your Java installation.
goto fail
:init
@rem Get command-line arguments, handling Windows variants
if not "%OS%" == "Windows_NT" goto win9xME_args
:win9xME_args
@rem Slurp the command line arguments.
set CMD_LINE_ARGS=
set _SKIP=2
:win9xME_args_slurp
if "x%~1" == "x" goto execute
set CMD_LINE_ARGS=%*
:execute
@rem Setup the command line
set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar
@rem Execute Gradle
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %CMD_LINE_ARGS%
:end
@rem End local scope for the variables with windows NT shell
if "%ERRORLEVEL%"=="0" goto mainEnd
:fail
rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
rem the _cmd.exe /c_ return code!
if not "" == "%GRADLE_EXIT_CONSOLE%" exit 1
exit /b 1
:mainEnd
if "%OS%"=="Windows_NT" endlocal
:omega
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.gradle.api.Project;
import org.gradle.api.attributes.AttributeContainer;
import org.gradle.api.file.FileCollection;
import org.gradle.api.internal.file.FileCollectionInternal;
import org.gradle.api.internal.file.UnionFileCollection;
import org.gradle.api.logging.Logger;
import org.gradle.api.tasks.CacheableTask;
Expand Down Expand Up @@ -95,9 +96,9 @@ public void generateHensonNavigator() {
TaskProvider<JavaCompile> javaCompiler = variant.getJavaCompileProvider();
FileCollection variantCompileClasspath = getJarDependencies();
FileCollection uft =
new UnionFileCollection(
javaCompiler.get().getSource(), project.fileTree(destinationFolder));
javaCompiler.get().setSource(uft);
new UnionFileCollection(
(FileCollectionInternal) javaCompiler.get().getSource(), (FileCollectionInternal) project.fileTree(destinationFolder));
javaCompiler.get().setSource(uft);
logger.debug("Analyzing configuration: " + variantCompileClasspath.getFiles());
Set<String> targetActivities = new HashSet<>();
Streams.stream(variantCompileClasspath)
Expand Down
2 changes: 1 addition & 1 deletion henson-plugin/src/main/resources/build.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#Tue Jul 02 10:47:11 PDT 2019
#Mon Sep 21 11:41:47 WIB 2020
dart.version=3.1.4-SNAPSHOT
1 change: 1 addition & 0 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ include 'dart-annotations'
include 'dart-common'
include 'dart'
include 'dart-processor'
include 'dart-processor-test'
include 'henson'
include 'henson-processor'
include 'henson-plugin'
Expand Down