Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cancellation support into io_uring_context #534

Merged
merged 1 commit into from
Oct 18, 2023
Merged

add cancellation support into io_uring_context #534

merged 1 commit into from
Oct 18, 2023

Conversation

janondrusek
Copy link
Contributor

@janondrusek janondrusek commented May 30, 2023 •
edited
Loading

Allows the io_uring_context Senders to complete with a cancellation signal and removes corresponding submissions from the ring.

@janondrusek janondrusek requested a review from ispeters May 30, 2023 15:47
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2023
ispeters
ispeters requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't feel like it's safe to merge this without doing something about how the io_uring_context handles the CQE for a cancelled operation; I feel like the current iteration is going to lead to invoking execute on a dead operation state.

include/unifex/linux/io_uring_context.hpp Outdated Show resolved Hide resolved
include/unifex/linux/io_uring_context.hpp Show resolved Hide resolved
@janondrusek janondrusek force-pushed the io-uring branch 2 times, most recently from e489bd9 to 8f6ec05 Compare October 18, 2023 21:50
ispeters
ispeters approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ispeters ispeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

test/io_uring_2_test.cpp Outdated Show resolved Hide resolved
@janondrusek
add cancellation support into io_uring_context
ac7796f 
* `open_listening_socket`
* `async_read_only_file`
* `async_write_only_file`
@janondrusek janondrusek merged commit ed0a3b5 into facebookexperimental:main Oct 18, 2023
35 checks passed
@janondrusek janondrusek deleted the io-uring branch October 18, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ispeters ispeters ispeters approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janondrusek @ispeters @facebook-github-bot