-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add range_search() to IndexRefine #4022
add range_search() to IndexRefine #4022
Conversation
@gtwang01 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
The unsuccessful check doesn't seem to be caused by this PR. |
@gtwang01 will do |
@alexanderguzhva Following up on this |
Signed-off-by: Alexandr Guzhva <[email protected]>
d0d3af7
to
9b9b023
Compare
Signed-off-by: Alexandr Guzhva <[email protected]>
@gtwang01 I've added a unit test. Please let me know if it is sufficient. Thanks. |
@gtwang01 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this
@gtwang01 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This is very convenient to have
range_seach()
inIndexRefine
. Unlike the plainsearch()
method,range_search()
just reevaluates the computed distances from the baseline index. The labels are not re-sorted according to new distances, because this is not listed as a requirement in a method descriptionfaiss/faiss/Index.h
Lines 150 to 161 in adb1884
faiss/faiss/impl/AuxIndexStructures.h
Line 35 in adb1884