-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Torch profiler #1156
Update Torch profiler #1156
Conversation
pre-commit.ci autofix |
@jicampos Can you have a look at the pre-commit failure? It looks like it is requesting a change in an |
Looks very good to me. One thing I noticed is that we are here: hls4ml/hls4ml/model/profiling.py Line 487 in 47939cb
nn.Sequential -type models. I think with this PR, that is no longer necessary, right?
|
@JanFSchulte You are right. I'm updating that now. I think adding a test would be beneficial as well. I don't see any implemented yet. |
Hi @jicampos I think this is basically ready, right? The only thing that would be nice to be added are pytests for it, is that something you can look into? |
@JanFSchulte That's correct—adding a test is all that's needed. I can look into it now that I'm back. |
I think the remaining test failures are totally unrelated to this PR, some connection errors in some of the QKeras tests. So I'll merge now. |
Description
Type of change
Currently, the profiler supports only sequential models with nn.Linear layers. This PR enhances its capabilities by:
Note: Please delete options that are not relevant.
Checklist
pre-commit
on the files I edited or added.