InABox: sort snapshots exclusively by created_at time #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had a minor bug where the wrong snapshot was spun up because it matched `fminabox-$version` but had additional stuff afterwards that sorted earlier This isn't a fix the issue it's possible to create non main builds that collide in snapshot name, but at least they'll time out being the snapshot synergy grabs in <24 hours
Davis-A
force-pushed
the
InABox-sort-created-date-only
branch
from
be7b732 to
cf38ec6
Compare
|
I would like to better understand the circumstances here. I'll catch up on Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a minor bug where the wrong snapshot was spun up because it matched
fminabox-$versionbut had additional stuff afterwards that sorted earlierThis isn't a fix the issue it's possible to create non main builds that collide in snapshot name, but at least they'll time out being the snapshot synergy grabs in <24 hours