Skip to content

Fixed compilation during RPM package build. - #36

Open
AlexanderShad wants to merge 1 commit into
fcitx:masterfrom
AlexanderShad:master
Open

AlexanderShad wants to merge 1 commit into
fcitx:masterfrom
AlexanderShad:master

Conversation

@AlexanderShad

@AlexanderShad AlexanderShad commented Oct 2, 2026 •

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes
    • Corrected how Lua header include paths are passed during CMake configuration. This helps keep build configuration consistent when the project is set up with Lua support. No changes to application features or behavior are included in this update.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d0d65da1-9482-4526-ad87-31a0bf0d657b

📥 Commits

Reviewing files that changed from the base of the PR and between 9bf8d3d and a6d7f15.

📒 Files selected for processing (1)
  • CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Lua::_LuaLibrary include-directory property now receives the expanded header-directory value as a quoted argument.

Changes

Lua include directories

Layer / File(s) Summary
Quote include-directory value
CMakeLists.txt
The INTERFACE_INCLUDE_DIRECTORIES assignment now quotes the expanded header-directory value.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: wengxt

Merge Risk: ⚪ Minimal · up to a6d7f

This change preserves Lua include directories for the add-on loader and addresses the reported RPM build issue. No remaining merge risk was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to a6d7f

The change affects 1 system.

Changed systems: CMakeLists.txt

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CMakeLists.txt (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CMakeLists.txt: The Lua::_LuaLibrary include-directory property now receives the expanded header-directory value as a quoted argument rather than an unquoted argument.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the purpose of the change: fixing compilation during RPM package builds. The change to quote INTERFACE_INCLUDE_DIRECTORIES supports this objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant