Skip to content

Create note in MR rather than a discussion #331

Description

@ckelleyRH

Unresolved threads in GitLab MRs block merges In CS/RHEL development. The MRs also require approval, which is not provided by automation in the case of failed builds, so it is not necessary to force the author to acknowledge the thread.

In this example, the author had the builds fail then succeed in a subsequent run. They got the necessary approvals, and resolved the failed results thread, but failed to notice that Log Detective had also opened a thread.

I think a note, which is non-blocking, is sufficient but it is possible I am missing supporting context and a discussion is in fact necessary.

From @sgallagher:

You're correct that we probably do not need to be starting a discussion and instead could be posting a note; that's an oversight on my part. (I think I was following a documentation example and didn't realize the difference inherent in starting a Discussion there).

However, this patch is nowhere near complete if we want to change this. Among other things, we actually store the Discussion ID in our database and use that to look up and suppress the earlier messages if and when a subsequent Log Detective analysis is run (such as when a new set of patches are pushed and the build fails again).

To solve this properly, we need to update all uses of Discussions to use Notes instead, which means also performing a database migration to convert existing entries to Note IDs instead of Discussion IDs.

As this is more involved than I had realised, I have created an issue to track it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions