Replace deprecated functions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago chrono deprecated some functions like NaiveDate::from_ymd and NaiveDate::from_num_days_from_ce. These functions panic if their arguments are out of range.
I replaced the calls to these functions with their recommended alternatives (NaiveDate::from_ymd_opt and NaiveDate::from_num_days_from_ce_opt).
Most of the time I just unwrap/except, since this is equivalent behaviour to before.
Alternatives would be changing some APIs to return Results/Options or using alternative functions where possible.
Most occurrences of these calls are in tests anyway where that should not matter.