Repository navigation
feat(core): take the message data shapes from @seamless-auth/types - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4.
Changes
@seamless-auth/messagingnow depends on@seamless-auth/types(^0.33.0) and re-exports the shared definitions instead of declaring its own copies:MessagingChannel,DeliveryResultandSmsMessageinpackages/core/src/types.tsSendOtpEmailInput,SendOtpSmsInputandSendMagicLinkEmailInputinpackages/core/src/messages.tsAuthDeliveryInstructionis newly exported, so a transport author can type the payload the API returns in external delivery mode without a second importAll imports are
import type, so the compiled JavaScript does not load@seamless-auth/typesor Zod. The dependency is there for the published.d.tsfiles.What stays local
Two shapes are not in the shared package yet, so they stay here:
EmailMessageis the sharedEmailMessageextended withheaders, which landed here in feat(email): carry custom headers through to SES #14 after@seamless-auth/typespublished its copy. Dropping it would break the SES v2 header support.SendEnrollmentInviteEmailInputhas no shared counterpart.Once
@seamless-auth/typescarries both, these become plain re-exports.EmailTransport,SmsTransport, the handler and override types,AuthMessagingServiceand the provider configs stay here as the issue describes, since they carry implementation rather than data.Checks
npm run typecheck,npm run lint,npm run format:checkandnpm test(12 passing) all pass locally.