Repository navigation
fix(release): name the repository in each package so provenance verifies - #18
Merged
Merged
Conversation
npm checks a provenance-signed publish against repository.url in the package manifest. The packages had none, so every 0.3.0 upload from the Release workflow was refused with E422. 0.2.0 was published by hand without provenance, which is why this only surfaced now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release run for #15 failed to publish all three packages at 0.3.0:
The workflow publishes with
NPM_CONFIG_PROVENANCE: true, and npm checks the signed provenance againstrepository.urlin each manifest. None of the packages had arepositoryfield. 0.2.0 was published by hand without provenance, so this is the first publish that hit the check.This adds
repository(withdirectory) tomessaging,messaging-awsandmessaging-twilio.No changeset: nothing reached npm, so 0.3.0 is still unpublished. Once this merges, the Release workflow finds no pending changesets and runs
changeset publish, which publishes 0.3.0.Checks: lint, format:check, typecheck and tests (12 passing).