Repository navigation
fix: sync the bundled adapter manifest with API 0.21.1 and check it in CI - #30
Merged
Merged
Conversation
The bundled copy was the API 0.19.4 manifest, so in fallback mode the v0.21 application, resource and OAuth provider discovery admin routes answered 404. Refs #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28.
What
manifest.jsonwith the adapter manifest seamless-auth-api main publishes (API 0.21.1, 130 routes, up from 0.19.4 and 115). The 15 added routes are the v0.21/admin/applications*and/admin/resources*routes andPOST /system-config/oauth-providers/{id}/discovery, which answered 404 whenever the adapter fell back to the bundled copy.scripts/check-manifest.sh, which compares the bundled copy with the API's (ignoringapiVersion) and lists missing and extra routes when they differ.manifestworkflow that runs the check on PRs, onmain, daily, and on demand, so an API route change shows up here without waiting for the next PR.AGENTS.md.The sync is a
fix:commit, so the release PR cuts a patch release.Checks
scripts/check-manifest.shpasses on this branch and fails on main, listing the 15 missing routes.cargo fmt --check, clippy with-D warningsandcargo test --locked(97 passed) pass.