Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): address shellcheck errs #39

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

vdice
Copy link
Member

@vdice vdice commented Jun 20, 2024

Note: these were caught on the merge to main as the same workflow did not run for the recent automated update PR (#38). I'm not sure why; @kate-goldenring any ideas?

@vdice vdice force-pushed the fix/shellcheck-errs branch 3 times, most recently from df25e36 to a20c89e Compare June 20, 2024 20:26
@vdice vdice force-pushed the fix/shellcheck-errs branch from a20c89e to f9d1132 Compare June 20, 2024 20:29
@vdice vdice requested a review from kate-goldenring June 20, 2024 20:37
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume since we are pulling in the homebrew action from the master branch (which looks to be the only option with no tags or releases or other branches) that this may be an update to the brew test-bot.

@vdice vdice merged commit 896cc72 into fermyon:main Jun 20, 2024
3 checks passed
@vdice vdice deleted the fix/shellcheck-errs branch June 20, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants