chore(*): migrate examples/templates/tests to Spin manifest v2 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
itowlson
approved these changes
Oct 27, 2023
| route = "/..." | ||
| component = "sqlite" | ||
|
|
||
| [component.sqlite] | ||
| source = "target/sqlite.wasm" | ||
| exclude_files = ["**/node_modules"] |
There was a problem hiding this comment.
I am puzzled why this excludes files that were not included but maybe safer to leave it?
There was a problem hiding this comment.
🤔 Yes I think I'll leave this one for another day
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates apps under
examples,templatesandtestto use Spin manifest v2While updating and testing, I also:
--follow-allonspin upnpm installprior tospin build(avoids thespin build-> 'would you like to install webpack?' -> 'yes' -> error ->spin build-> success)spin-http-jsturned into a more specific value)https://random-data-api.fermyon.app)Closes #203
Note: Should not be merged until Spin 2.0 is released. I've placed this in Draft due to this, but reviews/feedback appreciated in the meantime.This can be merged when ready per f3410b2