Bump ComponentizeJS to optionally enable AoT #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the following - updates the ComponentizeJS dependency to bring in AoT using weval. - Bumps the package version in preparation for a release. - Updates the templates and test to be able to use AoT and the newer package. Signed-off-by: karthik2804 <[email protected]>
|
Note: need to bump the version of spin_sdk dep in the template once a new release is done. |
radu-matei
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
The one thing I'm not sure about is whether we want to enable this by default.
Given the impact on the application size, and that it's not immediately relevant for applications that are not compute intensive, I would be in favor of making this an opt-in feature, rather than opt-out.
Signed-off-by: karthik2804 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following