Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloud v0.6.0 #48

Merged
merged 1 commit into from
Jan 10, 2024
Merged

add cloud v0.6.0 #48

merged 1 commit into from
Jan 10, 2024

Conversation

bacongobbler
Copy link
Member

No description provided.

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this needs to come in as cloud.json and the existing cloud.json needs to move to [email protected]. The file without the decorator should be the current one.

@bacongobbler
Copy link
Member Author

Ah! Thank you for the correction. Fixing

@bacongobbler
Copy link
Member Author

@itowlson quick question: is there any reason I shouldn't create [email protected] at the same time as I update cloud.json? I figured that would give users a way to pin to the current version.

Signed-off-by: Matthew Fisher <[email protected]>
@itowlson
Copy link
Contributor

@bacongobbler There are places where we scan the list of manifests (e.g. spin plugins search) and I think Spin could get confused if there were two manifests with the same version. I'm sure we could fix these to deduplicate, and it would make it easier to follow the diffs. I don't think we need it for pinning, though - I added something around badger time to make -v work correctly for the current version.

@bacongobbler bacongobbler merged commit 486b73e into main Jan 10, 2024
2 checks passed
@bacongobbler bacongobbler deleted the cloud-v0.6.0 branch January 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants