Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation notice to py2wasm #53

Closed
wants to merge 1 commit into from
+6 −6
Closed

add deprecation notice to py2wasm #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifests/py2wasm/py2wasm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "py2wasm",
"description": "A plugin to convert Python applications to Spin compatible modules",
"description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ",
"description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the latest SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components.",

"homepage": "https://github.com/fermyon/spin-python-sdk",
"version": "0.3.2",
"spinCompatibility": ">=1.5",
Expand Down Expand Up @@ -37,4 +37,4 @@
"sha256": "b0e35c6cfcc2f98b65ea80f074b9041d2818b06b5951d0d040018ce897ccb996"
}
]
}
}
2 changes: 1 addition & 1 deletion manifests/py2wasm/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "py2wasm",
"description": "A plugin to convert Python applications to Spin compatible modules",
"description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same typo fixes throughout. But really, is there much value in retrofitting to old versions? Is anyone going to install / update to these old versions at this point? The only scenario I can think of is if someone is on Spin 0.9 or whatever and the more recent version is incompatible, but those users won't be able to run componentize-py based components anyway will they?

"homepage": "https://github.com/fermyon/spin-python-sdk",
"version": "0.1.0",
"spinCompatibility": ">=0.9",
Expand Down
2 changes: 1 addition & 1 deletion manifests/py2wasm/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "py2wasm",
"description": "A plugin to convert Python applications to Spin compatible modules",
"description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ",
"homepage": "https://github.com/fermyon/spin-python-sdk",
"version": "0.1.1",
"spinCompatibility": ">=0.9",
Expand Down
2 changes: 1 addition & 1 deletion manifests/py2wasm/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "py2wasm",
"description": "A plugin to convert Python applications to Spin compatible modules",
"description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ",
"homepage": "https://github.com/fermyon/spin-python-sdk",
"version": "0.2.0",
"spinCompatibility": ">=0.9",
Expand Down
2 changes: 1 addition & 1 deletion manifests/py2wasm/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "py2wasm",
"description": "A plugin to convert Python applications to Spin compatible modules",
"description": "A plugin to convert Python applications to Spin compatible modules. Note: This plugin has been deprecated in favour of the newer SDK based on componentize-py. To move to the last SDK, uninstall the plugin and visit https://developer.fermyon.com/spin/v2/python-components ",
"homepage": "https://github.com/fermyon/spin-python-sdk",
"version": "0.3.0",
"spinCompatibility": ">=1.4",
Expand Down
Loading