Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger-kinesis to 0.2 version #73

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

ogghead
Copy link
Contributor

@ogghead ogghead commented Sep 18, 2024

Signed-off-by: Darwin Boersma [email protected]

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks @ogghead!

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ogghead Oops, sorry, I forgot we usually like to preserve all releases for a plugin.

Could you create a [email protected] file holding the 0.1.0 json? The update to trigger-kinesis.json with 0.2.0 release data can stay the same.

Here's an example PR doing similar: #66

@ogghead
Copy link
Contributor Author

ogghead commented Sep 18, 2024

Good callout, will update with that shortly and keep it in mind for future releases!

Signed-off-by: Darwin Boersma <[email protected]>
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last minute changes! LGTM.

@vdice vdice merged commit e177a63 into fermyon:main Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants