fix #2974 -- use redis::aio::ConnectionManager #2976
Merged
+82
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2974
This replaces the use of
redis::aio::MultiplexedConnection
withredis::aio::ConnectionManager
which automatically attempts to retry connecting upon error. See this for behavior ofConnectionManager
. To handle not passing on the first error to the user as described by "When a command sent to the server fails with an error that represents a “connection dropped” condition, that error will be passed on to the user..." relevant implementations ofStore
now implementafter_open()
which will to try ping the connection to trigger the automatic retry.