[URGENT] Fix two regressions in version 3.0.0 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the changes in PR #11 introduced two regressions:
The conditions in
binarystore.xml.eppstill used the old values and as a result$binary_provider_filesystem_dirwas never used.The logic in
config.ppwas incorrectly migrated from the EPP template to the manifest in revision 4a07e9c, which resulted in unexpected binarystore configuration.Besides fixing these two regressions I've added a few new tests to verify that the binarystore configuration contains the expected options. It should make it more difficult to break this again in the future. :)
If you accept this PR, then please create a new release on GitHub and on Puppet Forge, because loosing the binarystore configuration is a critical bug.