Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing webpackIgnore is crucial for a successful Webpack build. #613

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

baszczewski
Copy link
Contributor

Without this change, I've got an error here:

Compiled with problems:
×
WARNING in ./node_modules/@ffmpeg/ffmpeg/dist/esm/worker.js 20:39-21:35
Critical dependency: the request of a dependency is an expression

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for ffmpegwasm canceled.

Name Link
🔨 Latest commit b4e96ee
🔍 Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/6532199921570b000843014a

@jeromewu
Copy link
Collaborator

Thanks for the contribution! I think this is a great fix for many people.

@jeromewu jeromewu merged commit 7679537 into ffmpegwasm:main Oct 24, 2023
6 checks passed
@KritR
Copy link

KritR commented Dec 17, 2023

Hey sorry to bother here, any plans for a release with this fix? @jeromewu.

@incidentist
Copy link

This PR was merged, but was overwritten in this commit, so it didn't go out in the latest release and never will unless it's re-done: 083397a

@jeromewu
Copy link
Collaborator

This PR causes this error in the official website, thus temporary reverted in master branch
image

@jeromewu
Copy link
Collaborator

This issue only happens in production mode, ex:

npm run build
npm run serve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants