Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidying up dockerfile RUN examples and text #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

obigriffith
Copy link
Collaborator

While editing end module 6, I noticed that there is complete overlap between modules 5.3 - 5.4 and first half of module 6. I'm not sure if this was intended and wonder if something different was meant for the beginning of module 6.

Copy link
Contributor

github-actions bot commented Dec 26, 2024

No broken url errors! 🎉
Comment updated at 2024-12-26-20:30:36 with changes from 41f10de

Copy link
Contributor

github-actions bot commented Dec 26, 2024

No spelling errors! 🎉
Comment updated at 2024-12-26-20:30:34 with changes from 41f10de

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the beginning of Module 6, opening paragraph and section 6.1 are completely identical to modules 5.3 - 5.4. I'm not sure what was intended here. Perhaps module 6 was meant to start with something different?

Copy link
Contributor

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-12-26 with changes from the latest commit 41f10de

Comment on lines -261 to 264
> **FROM** creates a layer from the another Docker image.
> **CMD** specifies what command to run within the container.
> **RUN** builds your application with make.
> **FROM** creates a layer from another Docker image.
> **CMD** specifies the default command to run when a container is started from an image.
> **RUN** executes commands during the build process of the Docker image.
> **COPY** adds files from your Docker client’s current directory.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this block is being formatted as intended. It currently appears as a code/quoted text block with each line one after the other. I wonder if some kind of bulleted list was intended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a quote so that's why I indented it but I should make that clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants