-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wasmtime v25 #2059
feat: wasmtime v25 #2059
Conversation
Importantly, this reverts a previous wasmtime change that enabled trace-logging in regalloc, massively slowing down compilation across all FVM versions. fixes #2058
// wasmtime default: true | ||
// Disable extended const support. We'll probably enable this in the future but that requires a | ||
// FIP. | ||
c.wasm_extended_const(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is new, but all I'm doing here is disabling support for wasm modules that use this feature.
// wasmtime default: false | ||
// Disable the component module. | ||
#[cfg(feature = "wasmtime/component-model")] | ||
c.wasm_component_model(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't new in this version, I'm just explicitly disabling it (it should already be disabled).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2059 +/- ##
==========================================
+ Coverage 75.70% 75.72% +0.01%
==========================================
Files 153 153
Lines 15667 15677 +10
==========================================
+ Hits 11861 11871 +10
Misses 3806 3806
|
(going to write a benchmark now to confirm that this is fixed) |
Benchmark in #2060, but I'm not seeing any compilation time changes between this version, v4.4, and v4.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing that so quickly!
Importantly, this reverts a previous wasmtime change that enabled trace-logging in regalloc, massively slowing down compilation across all FVM versions.
fixes #2058