Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wasmtime v25 #2059

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat: wasmtime v25 #2059

merged 1 commit into from
Oct 21, 2024

Conversation

Stebalien
Copy link
Member

Importantly, this reverts a previous wasmtime change that enabled trace-logging in regalloc, massively slowing down compilation across all FVM versions.

fixes #2058

Importantly, this reverts a previous wasmtime change that enabled
trace-logging in regalloc, massively slowing down compilation across all
FVM versions.

fixes #2058
// wasmtime default: true
// Disable extended const support. We'll probably enable this in the future but that requires a
// FIP.
c.wasm_extended_const(false);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new, but all I'm doing here is disabling support for wasm modules that use this feature.

// wasmtime default: false
// Disable the component module.
#[cfg(feature = "wasmtime/component-model")]
c.wasm_component_model(false);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't new in this version, I'm just explicitly disabling it (it should already be disabled).

@Stebalien Stebalien requested review from rjan90, lemmih and LesnyRumcajs and removed request for rjan90 and lemmih October 18, 2024 15:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.72%. Comparing base (a0f85fa) to head (2d3ce72).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
+ Coverage   75.70%   75.72%   +0.01%     
==========================================
  Files         153      153              
  Lines       15667    15677      +10     
==========================================
+ Hits        11861    11871      +10     
  Misses       3806     3806              
Files with missing lines Coverage Δ
fvm/src/engine/mod.rs 86.57% <100.00%> (+0.28%) ⬆️

@Stebalien
Copy link
Member Author

(going to write a benchmark now to confirm that this is fixed)

@Stebalien
Copy link
Member Author

Benchmark in #2060, but I'm not seeing any compilation time changes between this version, v4.4, and v4.3.

@Stebalien Stebalien requested a review from rvagg October 21, 2024 16:41
Copy link
Contributor

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing that so quickly!

@Stebalien Stebalien merged commit 480a6ba into master Oct 21, 2024
16 checks passed
@Stebalien Stebalien deleted the steb/wasmtime-v25 branch October 21, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Investigation] Reported performance regression when updating wasmtime from 19 to 24.
3 participants