-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spectral rules to validate that interfaces are defined on the specific node referenced (169) #743
Conversation
e0461d0
to
ffbce33
Compare
Would be good to get input from @Thels here before I merge - I needed to npm install rollup for the spectral CI job to work, and I also needed to add link to the dev dependencies to prevent an error in the CI jobs. Not sure how that was merged in - I was seeing the issues on CI too so not just my machine. RE the CI jobs, I think we should probably just replace the Spectral CI job with running the CLI directly anyway - make things more consistent and use our own tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spent time with @willosborne to understand why we needed to package install link
package but the use-case he encountered was completely valid.
As discussed we do need to consider updating all of the node versions used in the GH actions soon as they're out of sync with the project itself.
Addresses #169
Adds a new rule; technically this overlaps with the 'not defined anywhere' rule which I could probably cut.
But 'not defined anywhere' and 'not defined on the right node' are different data points in my mind.
Could merge them into one, what do people think?