Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional top level nodes #92

Closed
wants to merge 7 commits into from

Conversation

willosborne
Copy link
Member

@willosborne willosborne commented Apr 2, 2024

In the event that additional properties are desirable on a pattern, this should be included in the instantiation. This just treats extra policies in the same way as properties defined in the prefixItems section of nodes or relationships.

Other changes:

  • warning when items used instead of prefixItems
  • substantial improvements to tests
  • migration to use winston logger more consistently and remove use of console.log

@willosborne willosborne requested a review from a team as a code owner April 2, 2024 15:30
@rocketstack-matt
Copy link
Member

It would be good to discuss this, I'm still unsure if our current samples where we're defining additional properties that aren't part of the core schema are valid or if we're missing key properties and we're going to end up with duplication and lack of standardisation.

@willosborne willosborne marked this pull request as draft April 3, 2024 15:33
@willosborne
Copy link
Member Author

Locked for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants