Repository navigation
fix: decode MCP SSE events and select matching replies - #16
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP MCP preflight currently parses the last data line, so a JSON-RPC response followed by a progress notification becomes an empty tool list. A valid SSE event with multiline JSON data also fails to decode. Parse complete data events and select the reply matching the initialize/tools-list request id, retaining ordinary JSON responses.
Validation: actual localhost HTTP peers reproduce both defects on unchanged main (2 fail, 1 JSON control pass). Fixed branch: all135 repository tests pass, including all three public list_http wire scenarios. git diff --check passes. No provider/model calls or scoring changes. This handles finite HTTP response bodies; it does not claim a live vendor/network run.