Validate the configuration path for Google Cloud Storage at start time #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
commented
May 13, 2020
| // Note that an empty string is a valid value: in that case the lib will try | ||
| // to find the authentication information from other means. | ||
| try { | ||
| fs.accessSync(googleAuthenticationFilePath, fs.constants.R_OK); |
There was a problem hiding this comment.
I use the synchronous version of the function because this is running at start time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple patch to validate the configuration for GCS.
Indeed if the path is incorrect the GCS lib returns the underlying "file not found" error, which is special-cased in koa to return a http status 404. When locally testing this was a bit painful.
Instead we validate this value when starting the server. I feel this is more correct.