Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases/v0.12.latest #87

Merged
merged 17 commits into from
Jun 11, 2024
Merged

Releases/v0.12.latest #87

merged 17 commits into from
Jun 11, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Jun 7, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

v0.12.1

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🪲 Bug Fixes 🪛

  • Added support for a new delayed fulfillment event status from Shopify. delayed has been added to the accepted_values test on stg_shopify__fulfillment_event (PR #84).
  • Added product_id to the unique combination_of_columns test for the stg_shopify__product_image model (PR #86).

Contributors

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:
Confirmed by customers who authored PRs. Will also add validation tests to the transform PR

If you had to summarize this PR in an emoji, which would it be?

🗺️

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-avinash fivetran-avinash self-requested a review June 11, 2024 19:00
@fivetran-jamie fivetran-jamie merged commit 34a31b2 into main Jun 11, 2024
8 checks passed
ranjeetmqat added a commit to MarqueeBrands/dbt_marquee_shopify_source that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants