-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases/v0.12.latest #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test to include new 'delayed' status from Shopify
Update accepted_values test in stg_shopify__fulfillment_event_status to include new 'delayed' status from Shopify
…__product_image-test adding product_id to uniqueness test
7 tasks
fivetran-joemarkiewicz
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fivetran-avinash
approved these changes
Jun 11, 2024
ranjeetmqat
added a commit
to MarqueeBrands/dbt_marquee_shopify_source
that referenced
this pull request
Jun 19, 2024
This reverts commit 34a31b2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
v0.12.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🪲 Bug Fixes 🪛
delayed
fulfillment event status from Shopify.delayed
has been added to theaccepted_values
test onstg_shopify__fulfillment_event
(PR #84).product_id
to the uniquecombination_of_columns
test for thestg_shopify__product_image
model (PR #86).Contributors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Confirmed by customers who authored PRs. Will also add validation tests to the transform PR
If you had to summarize this PR in an emoji, which would it be?
🗺️