Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.1.0 #85

Closed
wants to merge 3 commits into from
Closed

update to 1.1.0 #85

wants to merge 3 commits into from

Conversation

mikelpr
Copy link

@mikelpr mikelpr commented Jul 17, 2024

  • update strawberry to 1.1.0
  • update boost to 1.85.0, TagLib to 1.13.1, vlc to 3.0.21 and libusb to 1.0.27

didn't update KDE SDK to 6.7 as I kept hitting build errors, and didn't know how to update protobuf since protobuf-cpp is gone from their releases

@mikelpr mikelpr mentioned this pull request Jul 17, 2024
@mikelpr
Copy link
Author

mikelpr commented Jul 17, 2024

fail-6.7.log
attaching log of build failure when trying to build with org.kde.Sdk//6.7

builds just fine with 6.6 which I kept within this PR

@flathubbot
Copy link
Contributor

Started test build 135093

@flathubbot
Copy link
Contributor

Build 135093 failed

@Zishan-Rahman
Copy link
Contributor

Zishan-Rahman commented Jul 17, 2024

@mikelpr (sorry for the ping) The test build failed purely because of a AppStream validation error. I have a PR open, #81, that addresses said error (it also specifies in a patch to the org.strawberrymusicplayer.strawberry.appdata.xml file that the Flatpak is unofficial, as well as resolving #76). You may want to either merge my changes into your PR or rebase them onto it. Once you do whatever you think is best (I don't mind either merging or rebasing), I can close #81, and once your PR is merged after that, #76 can also be closed.

@mikelpr
Copy link
Author

mikelpr commented Jul 17, 2024

@Zishan-Rahman, no problem with the ping and taking the liberty to do so back :) oddly I'm getting crashes after selecting folders via portals, like on Playlist -> Add folder, and Transcode dialog -> Select (destination), so let me check what's up with that before going further

@mikelpr
Copy link
Author

mikelpr commented Jul 17, 2024

also, apparently flathubbot took care of doing the round of updates with PR #83 lol. it just missed updating TagLib (thinking because it's missing x-checker-data) and the shared-modules (for libusb)

@mikelpr mikelpr closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants