Repository navigation
feat(products): expose add-on category limits on public product payloads - #118
Merged
Merged
Conversation
… on public product payloads
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 2282 2283 +1
===========================================
Files 182 182
Lines 9082 9086 +4
===========================================
+ Hits 9082 9086 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The public product payload (
GET storefront/v1/products/{id}and every resource that embeds products) now includes each add-on category's limits, so apps can enforce them before checkout:addon_categories[].is_required(boolean,falsewhen unset)addon_categories[].max_selectable(integer, ornullfor no limit)The internal (Console) payload gains the same two fields. Both already exist on
ProductAddonCategoryand are editable in the Console.Variant
maxis intentionally not exposed. The Console has no field for it and the column defaults to1, so publishing it would cap every multi-select variant at a single choice.Tests
ProductResourceTestasserts both fields on public and internal payloads, plus the unset case (optional, no limit).