-
Notifications
You must be signed in to change notification settings - Fork 104
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add trailing slash to test exemption dir paths (#4034)
In `GithubWebhookSubscription._isTestExempt` we exempt a collection of directories (in both the framework and the engine) from tests by checking if the filename starts with the directory path. This adds a trailing slash to any such checks. Since `git` only stores files (not directories), all such paths will include a trailing slash. This avoids accidentally exempting directories such as `impeller/fixtures_that_actually_ship` when we only intended to exempt `impeller/fixtures`. Alright, bad example, but perhaps someday someone would have added something more ambiguous.
- Loading branch information
Showing
2 changed files
with
38 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters