Skip to content

[material_ui] Fix InputDecorator intrinsic height when isDense or isC… - #13522

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
mmohankrishna-lab:fix-input-decorator-intrinsic-height-190536
Nov 5, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
mmohankrishna-lab:fix-input-decorator-intrinsic-height-190536

Conversation

@mmohankrishna-lab

@mmohankrishna-lab mmohankrishna-lab commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

_RenderDecoration.computeMinIntrinsicHeight computed the minimum container height differently from _layout:

Condition Floor
_layout isDense || isCollapsed || expands inputHeight
computeMinIntrinsicHeight (before) isDense || expands 0.0

This caused two mismatches between the intrinsic height and the laid out height:

  1. isDense: true with compact visual density (the default on desktop and web): the density offset (-8) shrinks the content height below the input height. Layout clamps it back up to inputHeight, but the intrinsic path clamped to 0.0, so the intrinsic height was 8px too short. Inside IntrinsicHeight, this produced the A RenderFlex overflowed by 8.0 pixels error reported in the issue.
  2. isCollapsed: true without isDense (including InputDecoration.collapsed): the intrinsic path still applied the kMinInteractiveDimension (48px) floor, while layout used inputHeight, so the intrinsic height was too tall.

This PR aligns computeMinIntrinsicHeight with _layout.

Density Decoration Laid out height Intrinsic before Intrinsic after
compact isDense + isCollapsed, zero padding 24 16 24
compact isDense, zero padding 24 16 24
standard / compact isCollapsed 24 48 24
standard / compact InputDecoration.collapsed 24 48 24

Fixes flutter/flutter#190536

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

…ollapsed is true

Aligns the minimum container height in computeMinIntrinsicHeight with the one used during layout, so the intrinsic height matches the laid out height for dense and collapsed decorations, including with compact visual density.

Fixes flutter/flutter#190536
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Nov 2, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Nov 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum intrinsic height calculation in InputDecorator to match its laid out height when isDense or isCollapsed is true, and adds corresponding regression tests. The review feedback recommends replacing the null-assertion operator on decoration.isDense! with decoration.isDense == true to avoid potential runtime exceptions.

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thank you!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2026
@auto-submit
auto-submit Bot merged commit f631bb8 into flutter:main Nov 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InputDecorator with IntrinsicHeight does not conform layout height when isDense: true or isCollapsed: true

2 participants