Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show this again toggle bug #460 #476

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: don't show this again toggle bug #460 #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
122d1c2
fix: don't show this again toggle bug #460
JoaoOliveira85 Sep 17, 2024
17a967b
updated changelog
JoaoOliveira85 Sep 26, 2024
fa9397e
Update .github/CHANGELOG.yaml
JoaoOliveira85 Oct 2, 2024
6fe91be
Merge branch 'master' into fix/dont-show-this-again-toggle-bug-460
JoaoOliveira85 Oct 23, 2024
2c10ef4
fix: implemented pr review suggestion
JoaoOliveira85 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/CHANGELOG.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@


releases:
- name: 3.4.2
changes:
- title: Fixed "Don't show this again" toggle button
categories: [UI]
authors: [JoaoOliveira85]
- name: 3.4.1
changes:
- title: Update installer default data for addon sources
Expand Down
3 changes: 2 additions & 1 deletion src/renderer/components/Modal/AutostartDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export const CompactYesNoOptionToggle: FC<YesNoOptionToggleProps> = ({
children,
}) => {
const handleClick = onToggle;
const voidFunction = () => {};

const borderColor = enabled ? 'border-cyan' : 'border-navy-light';
const titleColor = enabled ? 'text-cyan' : 'text-quasi-white';
Expand All @@ -118,7 +119,7 @@ export const CompactYesNoOptionToggle: FC<YesNoOptionToggleProps> = ({
className={`flex items-center gap-x-6 border-2 ${borderColor} transition-color cursor-pointer rounded-md px-6 py-5 duration-200`}
onClick={handleClick}
>
<Toggle value={enabled} onToggle={handleClick} scale={1.2} onColor={enabledBgColor} />
<Toggle value={enabled} onToggle={voidFunction} scale={1.2} onColor={enabledBgColor} />

<span className="flex gap-x-20">
<span className={`font-manrope text-3xl font-bold ${titleColor}`}>{children}</span>
Expand Down
Loading