New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NaN results #15

Open

Megidd wants to merge 1 commit into fogleman:master from Megidd:fix-NaN

Megidd commented May 16, 2020 •

edited

Loading

Observation

Occasional NaN results are observed. For example when up input for Orient is:

or:

Inside func RotateTo(a, b Vector), the statement v := b.Cross(a).Normalize() result is:

Proposed solution

To avoid NaN results, approximate float comparison is done by this package. Having done so, the NaN results are no loner observed.


          Avoid occasional NaN results

32071b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet