Add labels and resizing to fields for accessibility on add connection… #3793
Conversation
| Button { | ||
| save() | ||
| } label: { | ||
| Text("Done").bold() |
There was a problem hiding this comment.
I realized there’s a snag here— the old code uses [[UIBarButtonItem alloc] initWithBarButtonSystemItem:UIBarButtonSystemItemDone… and the system takes care of localization but I haven’t been able to find an equivalent in Swift UI so far (I found someone else’s tweet with the same question and no answers 😬). I could also add this to our localizable strings which feels a little annoying but we already needed new entries to split the field labels and placeholders so maybe not as bad to do all at once?
There was a problem hiding this comment.
There does not seem to be an equivalent in Swift UI, so you probably have to add a localized string for done.
There was a problem hiding this comment.
I have one more change for the tint color of the button, I'll open another PR because I touched a bunch of files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3793 +/- ##
==========================================
+ Coverage 62.75% 62.86% +0.10%
==========================================
Files 224 225 +1
Lines 21358 21471 +113
==========================================
+ Hits 13404 13498 +94
- Misses 7954 7973 +19
|
… screen
Screen with new design:
and example with large text:
