feat: create apex action from selected method/this class #5950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cedx-vscode into cristi/apex-actions
CristiCanizales
changed the title
CristiCanizales
requested review from
peternhale,
mingxuanzhangsfdx and
daphne-sfdc
and removed request for
lahernandezb
CristiCanizales
changed the title
| }; | ||
|
|
||
| public extractAllMethodsMetadata = (): MethodMetadata[] | undefined => { | ||
| const editor = vscode.window.activeTextEditor; |
There was a problem hiding this comment.
I think there is a use case that the active text editor is not available when we right click on one apex source file in the file explorer.
packages/salesforcedx-vscode-apex/src/commands/createApexAction.ts
Outdated
Show resolved
Hide resolved
peternhale
reviewed
Nov 20, 2024
There was a problem hiding this comment.
@CristiCanizales aside from the comments from Mingxuan and the 3pp check, very nice job of laying the foundation of the work that follows!
| @@ -57,6 +57,7 @@ | |||
| "markdown-link-check": "^3.9.3", | |||
| "ncp": "^2.0.0", | |||
| "nyc": "15.1.0", | |||
| "openapi-types": "12.1.3", | |||
There was a problem hiding this comment.
@CristiCanizales please verify the 3pp status of the new modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
@ W-17236284@, @W-17236576@, @W-17236448@, @W-17236508@