Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent Request textDocument/documentHighlight failed with message: Debug Failure. False expression. Code: -32603 error when selecting Javascript code in the embedded <script> tag #5975

Merged
merged 3 commits into from
Dec 17, 2024
+2 −1
Merged

fix: prevent Request textDocument/documentHighlight failed with message: Debug Failure. False expression. Code: -32603 error when selecting Javascript code in the embedded <script> tag #5975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4054b3
Visualforce extension - prevent "Request textDocument/documentHighlig…
AndrewStopchenko-SO Dec 13, 2024
c9929f5
Merge branch 'develop' into patch-visualforceLanguageServer
AndrewStopchenko-SO Dec 16, 2024
3a34fe1
Update packages/salesforcedx-visualforce-language-server/src/modes/ja…
mingxuanzhangsfdx Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/salesforcedx-visualforce-language-server/src/modes/javascriptMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,11 @@ export const getJavascriptMode = (documentRegions: LanguageModelCache<HTMLDocume
findDocumentHighlight: (document: TextDocument, position: Position): DocumentHighlight[] => {
updateCurrentTextDocument(document);
const highlights = jsLanguageService.getDocumentHighlights(FILE_NAME, currentTextDocument.offsetAt(position), [
FILE_NAME,
document.uri
]);

if (highlights.length > 0) {
if (highlights?.length > 0) {
// Only one file to search above so there should only be one result
return highlights[0].highlightSpans.map(entry => {
return {
Expand Down
Loading