Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gather context #5988

Merged
merged 10 commits into from
Jan 2, 2025
Merged

feat: gather context #5988

merged 10 commits into from
Jan 2, 2025

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Updates jar and creates util to gather context

What issues does this PR fix or reference?

@W-17260440@

@CristiCanizales CristiCanizales self-assigned this Dec 31, 2024
@CristiCanizales CristiCanizales requested a review from a team as a code owner December 31, 2024 05:42
@CristiCanizales CristiCanizales requested review from peternhale, daphne-sfdc and madhur310 and removed request for gimijose December 31, 2024 05:44
@@ -140,6 +160,7 @@ export class MetadataOrchestrator {
requests.push(request);
}

const response = this.gatherContext(sourceUri);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CristiCanizales I was thinking that context gathering would occur after eligibility is determined and the class is eligible for generation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Right now it's just like a placeholder so we can play with the response when doing prompt engineering

mingxuanzhangsfdx and others added 5 commits December 31, 2024 11:49
* chore: eligibility criteria for class and method annotations

* chore: update rest-related annotations

* feat: latest jorje jar

* chore: pin vsp version
Copy link
Contributor

@peternhale peternhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CristiCanizales just a couple of var/label changes around eligibility. Could you do the noted changes in your next PR?

@CristiCanizales CristiCanizales merged commit 89b0928 into feat/apex-oas Jan 2, 2025
5 checks passed
@CristiCanizales CristiCanizales deleted the cristi/gather-context branch January 2, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants