Skip to content

Translating FormEdit #522

Closed
Closed

Description

@PatrikTrefil

Labels in FormEdit such as this one should be passed through i18next to allow for translations. The same goes for placeholder values.

I am willing to make a PR. I just need confirmation that this change is desired.

Activity

  1. brendanbond commented on Jul 25, 2023

    @brendanbond
    Contributor

    PRs are welcome, but this library is a wrapper around our core Javascript renderer, any translations (including labels) already occur there. If there's a specific issue you're running into, please provide a minimally reproducible example. Thanks!

  2. PatrikTrefil commented on Jul 26, 2023

    @PatrikTrefil
    Author

    The FormEdit component renders a FormBuilder and some extra input fields such as Title, Path, etc. The extra fields can't be translated. As you can see on this line the label has value "Title", which is a string constant rather than something passed through an internalization library.

    Minimally reproducible example: User of this library can not translate the label Title, which is rendered by the FormEdit component (this is not handled by the core JS render).

  3. brendanbond commented on Jul 26, 2023

    @brendanbond
    Contributor

    Ah, I see what you mean. Yeah, I'd happily review a PR for this.

  4. PatrikTrefil commented on Nov 2, 2023

    @PatrikTrefil
    Author

    Please review the PR I made.

  5. brendanbond commented on Nov 2, 2023

    @brendanbond
    Contributor

    hey @PatrikTrefil see my comments

  6. olgabann commented on Sep 4, 2024

    @olgabann

    Thank you for your contribution. As this issue has been inactive for over 90 days, I will close it for now. If you'd like to reopen the issue, please reply and we can resume the triage process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions