You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PRs are welcome, but this library is a wrapper around our core Javascript renderer, any translations (including labels) already occur there. If there's a specific issue you're running into, please provide a minimally reproducible example. Thanks!
The FormEdit component renders a FormBuilder and some extra input fields such as Title, Path, etc. The extra fields can't be translated. As you can see on this line the label has value "Title", which is a string constant rather than something passed through an internalization library.
Minimally reproducible example: User of this library can not translate the label Title, which is rendered by the FormEdit component (this is not handled by the core JS render).
Thank you for your contribution. As this issue has been inactive for over 90 days, I will close it for now. If you'd like to reopen the issue, please reply and we can resume the triage process.
Activity
brendanbond commentedon Jul 25, 2023
PRs are welcome, but this library is a wrapper around our core Javascript renderer, any translations (including labels) already occur there. If there's a specific issue you're running into, please provide a minimally reproducible example. Thanks!
PatrikTrefil commentedon Jul 26, 2023
The
FormEditcomponent renders aFormBuilderand some extra input fields such as Title, Path, etc. The extra fields can't be translated. As you can see on this line the label has value"Title", which is a string constant rather than something passed through an internalization library.Minimally reproducible example: User of this library can not translate the label Title, which is rendered by the
FormEditcomponent (this is not handled by the core JS render).brendanbond commentedon Jul 26, 2023
Ah, I see what you mean. Yeah, I'd happily review a PR for this.
PatrikTrefil commentedon Nov 2, 2023
Please review the PR I made.
brendanbond commentedon Nov 2, 2023
hey @PatrikTrefil see my comments
olgabann commentedon Sep 4, 2024
Thank you for your contribution. As this issue has been inactive for over 90 days, I will close it for now. If you'd like to reopen the issue, please reply and we can resume the triage process.