Repository navigation
Conversation
|
@thavguard is attempting to deploy a commit to the Formkit Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a
<tr>during its entry animation throws when its positioned ancestor has no cached coordinates. WebKit explicitly resetsposition: relativetostaticon table row groups (engine source), so AutoAnimate can walk past the observedtbodyto an unobserved wrapper.Fall back to measuring that ancestor when its cache entry is missing. The production change is one line.
Fixes #248.
The regression test uses a plain HTML table, default options and unchanged styles. It verifies that a row removed during entry is cleaned up without an exception and its sibling survives. Run it in Chromium and WebKit:
Focused CI: unpatched core — Chromium passes, WebKit fails with
parentCoords.top; patched core — both pass. The same minimal test is used in both runs.