Fix libfmt dependency #173
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As libfmt is included in public headers, we should declare the dependency transitively.
This is required to ship version 0.9.2 and a newer one via the same .deb repo.
rhaschke
commented
Jan 8, 2025
| @@ -14,9 +14,12 @@ | |||
| <url type="bugtracker">https://github.com/frankaemika/libfranka/issues</url> | |||
| <author>Franka Robotics GmbH</author> | |||
|
|
|||
| <replace version_lt="10.0">libfranka</replace> | |||
There was a problem hiding this comment.
Not sure yet, whether this is the correct tag. See rhaschke/franka_ros#4 (comment).
Are versions 0.9.2 and >= 0.10 ABI compatible at all? If not, one needs to build separate versions of franka_ros as well. How to you serve customers wanting to operate both, Panda (requiring 0.9.2) and FR3 (requiring >= 0.10), from the same machine? This would need parallel installs of both versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #171
CPACK_DEBIAN_PACKAGE_DEPENDS). This is required for ROS.libfranka/CMakeLists.txt
Line 219 in fd2951b